obs: improve spans use in flashbots submit #165
+36
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanlott
changed the title
prestwich
requested changes
Oct 23, 2025
src/tasks/submit/flashbots.rs
Outdated
| // Prepare a MEV bundle with the configured call type from the sim result | ||
| let Ok(bundle) = | ||
| self.prepare(&sim_result).instrument(span.clone()).await.inspect_err(|error| { | ||
| let bundle = match self.prepare(&sim_result).instrument(span.clone()).await { |
There was a problem hiding this comment.
i somewhat prefer the let Ok(_) else
dylanlott
force-pushed
the
dylan/flashbots-span
branch
from
45f8e09 to
8951b43
Compare
prestwich
reviewed
Oct 27, 2025
|
|
||
| // Send the bundle to Flashbots, instrumenting the send future so all | ||
| // events inside the async send are attributed to the submit span. | ||
| let response = async { |
There was a problem hiding this comment.
the future is instumented directly. no need to use the async block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves span usage in the Flashbots submit task for better tracking in groundcover and analytics.